[PATCH v5 1/3] iio: adc: ingenic-adc: rename ingenic_adc_enable_unlocked() function
Felipe Ribeiro de Souza
felipers em ime.usp.br
Ter Maio 5 22:58:28 -03 2026
Rename ingenic_adc_enable_unlocked() to __ingenic_adc_enable() to
better reflect that this helper must be called with the lock held.
Signed-off-by: Felipe Ribeiro de Souza <felipers em ime.usp.br>
Co-developed-by: Lucas Ivars Cadima Ciziks <lucas em ciziks.com>
Signed-off-by: Lucas Ivars Cadima Ciziks <lucas em ciziks.com>
---
v2:
- Adjust order of #include.
- Replace guard() in ingenic_adc_read_chan_info_raw() by scoped_guard()
to preserve original behavior.
v3:
- Split out ingenic_adc_read_chan_info_raw() logic to helper function.
v4:
- Adjust code style for better readability.
v5:
- Rename ingenic_adc_enable_unlocked() to __ingenic_adc_enable() and
ingenic_adc_read_chan_locked() to __ingenic_adc_read_chan() to keep
the convention about the locked functions name.
- Move the mutex lock back to ingenic_adc_read_chan_info_raw().
---
drivers/iio/adc/ingenic-adc.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/adc/ingenic-adc.c b/drivers/iio/adc/ingenic-adc.c
index 1e802c8779a4c..231ff8d584c2d 100644
--- a/drivers/iio/adc/ingenic-adc.c
+++ b/drivers/iio/adc/ingenic-adc.c
@@ -181,9 +181,8 @@ static void ingenic_adc_set_config(struct ingenic_adc *adc,
mutex_unlock(&adc->lock);
}
-static void ingenic_adc_enable_unlocked(struct ingenic_adc *adc,
- int engine,
- bool enabled)
+static void __ingenic_adc_enable(struct ingenic_adc *adc, int engine,
+ bool enabled)
{
u8 val;
@@ -202,7 +201,7 @@ static void ingenic_adc_enable(struct ingenic_adc *adc,
bool enabled)
{
mutex_lock(&adc->lock);
- ingenic_adc_enable_unlocked(adc, engine, enabled);
+ __ingenic_adc_enable(adc, engine, enabled);
mutex_unlock(&adc->lock);
}
@@ -222,11 +221,11 @@ static int ingenic_adc_capture(struct ingenic_adc *adc,
cfg = readl(adc->base + JZ_ADC_REG_CFG);
writel(cfg & ~JZ_ADC_REG_CFG_CMD_SEL, adc->base + JZ_ADC_REG_CFG);
- ingenic_adc_enable_unlocked(adc, engine, true);
+ __ingenic_adc_enable(adc, engine, true);
ret = readb_poll_timeout(adc->base + JZ_ADC_REG_ENABLE, val,
!(val & BIT(engine)), 250, 1000);
if (ret)
- ingenic_adc_enable_unlocked(adc, engine, false);
+ __ingenic_adc_enable(adc, engine, false);
writel(cfg, adc->base + JZ_ADC_REG_CFG);
mutex_unlock(&adc->lock);
--
2.43.0
Mais detalhes sobre a lista de discussão kernel