[PATCH v3 1/2] iio: light: veml6030: Remove 'x' wildcard usages in file
Marcelo Schmitt
marcelo.schmitt1 em gmail.com
Sáb Maio 23 17:17:04 -03 2026
Hello Gabriel, Ricardo, Ellian.
Patch looks okay overall. Maybe the '_desc' part of the renaming can be avoided?
veml603x_chip -> veml6030_chip
so the struct name doesn't become longer.
On 05/20, Gabriel Braga Lagrotaria wrote:
> Remove use of 'x' wildcard at struct veml603x_chip, as it is not
> particularly future-proof. Instead, use name veml6030_chip_desc.
>
> Signed-off-by: Gabriel Braga Lagrotaria <gabrielblo em ime.usp.br>
> Co-developed-by: Ricardo H H Kojo <ricardo.kojo em ime.usp.br>
> Signed-off-by: Ricardo H H Kojo <ricardo.kojo em ime.usp.br>
We usually use either full name (no abbreviations) or first and last name in tag name strings.
E.g. if Pedro II would contribute to Linux, his SoB would either be
Signed-off-by: Pedro Gonzaga <... em ...>
or
Signed-off-by: Pedro de Alcântara João Carlos Leopoldo Salvador Bibiano Francisco Xavier de Paula Leocádio Miguel Gabriel Rafael Gonzaga <... em ...>
Were there any updates to Linux contributor identification guidelines?
If no, I'd choose one of the above formats and go with that.
> Co-developed-by: Ellian Carlos <elliancarlos em gmail.com>
> Signed-off-by: Ellian Carlos <elliancarlos em gmail.com>
Mais detalhes sobre a lista de discussão kernel